Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: More tests for groups kick #30536

Merged
merged 3 commits into from
Oct 12, 2023
Merged

test: More tests for groups kick #30536

merged 3 commits into from
Oct 12, 2023

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Depends on #30523 and #30535

@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2023

⚠️ No Changeset found

Latest commit: 4a400bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #30536 (4a400bc) into develop (e8eeb2a) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #30536   +/-   ##
========================================
  Coverage    51.28%   51.29%           
========================================
  Files          811      804    -7     
  Lines        15074    15109   +35     
  Branches      2752     2767   +15     
========================================
+ Hits          7731     7750   +19     
+ Misses        6935     6932    -3     
- Partials       408      427   +19     
Flag Coverage Δ
e2e 48.62% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Base automatically changed from chore-refactor-e2e-test-groups to develop October 2, 2023 12:24
@sampaiodiego sampaiodiego force-pushed the more-tests-for-groups-kick branch from bb50c55 to 057fd55 Compare October 2, 2023 13:24
@sampaiodiego sampaiodiego force-pushed the more-tests-for-groups-kick branch from 057fd55 to b84ab64 Compare October 9, 2023 17:38
@sampaiodiego sampaiodiego marked this pull request as ready for review October 10, 2023 16:52
@sampaiodiego sampaiodiego requested a review from a team as a code owner October 10, 2023 16:52
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 12, 2023
@kodiakhq kodiakhq bot merged commit 389bac8 into develop Oct 12, 2023
43 checks passed
@kodiakhq kodiakhq bot deleted the more-tests-for-groups-kick branch October 12, 2023 20:46
gabriellsh added a commit that referenced this pull request Oct 16, 2023
…/mentionBot

* 'develop' of github.com:RocketChat/Rocket.Chat:
  feat: add tooltip to badge mentions (#30590)
  chore: improve `Tag` a11y link (#30636)
  refactor: Replace `useForm` in favor of RHF on `AppInstallPage` (#30634)
  fix: Improve FileProxy Handling, set Content-Type (#30427)
  refactor: `EditRoomInfo` to typescript (#28318)
  fix: mobile ringing notification missing call id (#30614)
  fix: Some HTTP requests sent by apps don't have their data parsed into JSON (#30560)
  test: More tests for groups kick (#30536)
  fix: Threads breaking after sending messages too fast (#30622)
  chore: Remove text decoration from room tag (#30606)
  i18n: Language update from LingoHub 🤖 on 2023-10-10Z (#30613)
  fix: File attachments have no content when exporting room messages as file (#30596)
  fix: use setImmediate to handle username update (#30500)
  chore: `AnalyticsReports` visual adequacy (#30617)
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants